Update MatrixRTCSession to increase push notification arrival time on mobile clients for element-call - #5398
Conversation
Updated the lifetime to increase the mobile push notification arrival timeout
github-actions
Bot
added
the
Z-Community-PR
Johennes
left a comment
Johennes
left a comment
There was a problem hiding this comment.
Thanks for your contribution. Your intent of increasing the notification lifetime to 60s seems reasonable. However, your changes don't appear to achieve that. Could you please fix the implementation?
Updated.
Updated as per comments
Johennes
left a comment
Johennes
left a comment
There was a problem hiding this comment.
Looks like the tests need updating.
@Johennes |
It appears that element-x has increased the call ringing time to 90seconds so matching the value to that. element-hq/element-x-android#3991
It appears that the element-x call notification has increased to 90seconds. So matching the timeout accordingly.
escix
left a comment
escix
left a comment
There was a problem hiding this comment.
Amended to match the element-x timeouts:
element-hq/element-x-android#3991
matrixrtc: restore RTC Slot support, rebase notificationLifetimeMs onto develop
escix
left a comment
escix
left a comment
There was a problem hiding this comment.
matrixrtc: restore RTC Slot support, rebase notificationLifetimeMs onto develop
Johennes
left a comment
Johennes
left a comment
There was a problem hiding this comment.
Sorry for the delay. I've been out on vacation. Thanks for the changes. Unfortunately, it looks like the linter still fails.
matrixrtc: reformat spec file per oxfmt
Johennes
left a comment
Johennes
left a comment
There was a problem hiding this comment.
CI is still not happy. Your latest change seems to have introduced a lot of unrelated formatting changes. Could you please run the checks that fail on CI locally to verify that you've fixed them?
Amended to match 90seconds. Also deleted a last empty line.
2 participants
Created by Claude.
Updated the lifetime to increase the mobile push notification arrival timeout
Checklist
public/exportedsymbols have accurate TSDoc documentation.